Fix: Inform about Boolean Parameters not for case class initializer #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccartney
approved these changes
May 10, 2022
| @@ -22,7 +22,7 @@ developers := List( | |||
| ) | |||
| ) | |||
|
|
|||
| scalaVersion := "2.13.7" | |||
| scalaVersion := "2.13.8" | |||
There was a problem hiding this comment.
That's probably not intended, but it doesn't matter much.
|
1.4.14 is on its way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made an error in my last PR because I didn't know that for any
case classwith a Boolean parameter the compiler actually creates a method called<init>in the automatically generated companion object that has the constructor parameters. In that method's parameters there's obviously also the Boolean parameter. We don't want to show an info forcase classes, though.This filters for these methods and adds a negative test as well.
Could we get this merged and released quickly?